Fix handler typo in billing alerts #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
requested changes
Feb 21, 2022
| }); | ||
| }); | ||
|
|
||
| describe('onAutomatedPlanUpdatePublished', () => { |
There was a problem hiding this comment.
Suggested change
| describe('onAutomatedPlanUpdatePublished', () => { | |
| describe('onPlanAutomatedUpdatePublished', () => { |
taeold
approved these changes
Feb 21, 2022
src/v2/providers/alerts/billing.ts
Outdated
| export const planUpdateAlert = 'billing.planUpdate'; | ||
| /** @internal */ | ||
| export const automatedPlanUpdateAlert = 'billing.automatedPlanUpdate'; | ||
| export const planAutomatedUpdateAlert = 'billing.automatedPlanUpdate'; |
There was a problem hiding this comment.
huh this is bit odd. The event type is still automatedPlanUpdate not planAutomatedUpdate?
There was a problem hiding this comment.
Just double checked the alert type string, it's set to billing.automatedPlanUpdate. Since all their other methods and structures have this as planAutomatedUpdate, I'm going to request that they change this value on the provider end. I'll leave this PR up until it gets sorted out.
There was a problem hiding this comment.
What's in the spec? IDK if we should differ between the alerttype and the handler function name. It just seemed odd that this isn't object -> verb naming.
taeold
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
onAutomatedPlanUpdatePublished()with the correctonPlanAutomatedUpdatePublished()in billing alerts.